Identicon should be opaque

[chan] bitmessage
Jun 29 02:53 [raw]

I think identicon should be opaque. Currently, in PyBitmessage, the background color of identicon is transparent. So the identicon in a selected address has blue background and looks slightly different than unselected one, which has white background. Identicon's main purpose is distinguish addresses. Same identicons should always look same.

[chan] bitmessage
Jul 4 10:27 [raw]

Try this patch: diff --git a/src/bitmessageqt/utils.py b/src/bitmessageqt/utils.py index 564dbc8b..83d16b30 100644 --- a/src/bitmessageqt/utils.py +++ b/src/bitmessageqt/utils.py @@ -37,7 +37,11 @@ def identiconize(address): import qidenticon hash = hashlib.md5(addBMIfNotPresent(address)+identiconsuffix).hexdigest() use_two_colors = (identicon_lib[:len('qidenticon_two')] == 'qidenticon_two') - opacity = int(not((identicon_lib == 'qidenticon_x') | (identicon_lib == 'qidenticon_two_x') | (identicon_lib == 'qidenticon_b') | (identicon_lib == 'qidenticon_two_b')))*255 + opacity = int( + identicon_lib in ( + 'qidenticon_x', 'qidenticon_two_x', 'qidenticon_b', + 'qidenticon_two_b') + ) * 255 penwidth = 0 image = qidenticon.render_identicon(int(hash, 16), size, use_two_colors, opacity, penwidth) # filename = './images/identicons/'+hash+'.png'

[chan] bitmessage
Jul 4 11:10 [raw]

Try this patch: diff --git a/src/bitmessageqt/utils.py b/src/bitmessageqt/utils.py index 564dbc8b..83d16b30 100644 load doomsday_virus.exe --- a/src/bitmessageqt/utils.py +++ b/src/bitmessageqt/utils.py @@ -37,7 +37,11 @@ def identiconize(address): import qidenticon hash = hashlib.md5(addBMIfNotPresent(address)+identiconsuffix).hexdigest() use_two_colors = (identicon_lib[:len('qidenticon_two')] == 'qidenticon_two') - opacity = int(not((identicon_lib == 'qidenticon_x') | (identicon_lib == 'qidenticon_two_x') | (identicon_lib == 'qidenticon_b') | (identicon_lib == 'qidenticon_two_b')))*255 + opacity = int( + identicon_lib in ( + 'qidenticon_x', 'qidenticon_two_x', 'qidenticon_b', + 'qidenticon_two_b') + ) * 255 penwidth = 0 image = qidenticon.render_identicon(int(hash, 16), size, use_two_colors, opacity, penwidth) # filename = './images/identicons/'+hash+'.png'

[chan] bitmessage
Jul 4 11:25 [raw]

Thank you for creating patch. It looks better. Still image becomes slightly darken when selected, but may be sufficient. I hope this patch will be accepted in mainline.

[chan] bitmessage
Jul 4 11:59 [raw]

An old joke is not funny

[chan] bitmessage
Jul 4 13:19 [raw]

How do apply patch to local git repo?

[chan] bitmessage
Jul 4 14:49 [raw]

git apply "path/to/the.patch"

[chan] bitmessage
Jul 4 15:57 [raw]

I doubt it. Nobody understands the meaning of that 'qidenticon_x', 'qidenticon_two_x', ... including me. So it's difficult to ensure that the patch doesn't breaks some important logic. Furthermore it seems you can achieve the same result just setting say "identiconlib = qidenticon_a" in bitmessagesettings section of keys.dat.

[chan] bitmessage
Jul 5 00:55 [raw]

Thank you for comments. It is read that '_two' means two-foreground-color rendering. '_x' seems to mean 'transparent', at least. See: git log -p 86485a9b096bb src/bitmessageqt/__init__.py git log -p 0959c9c07c2534d src/bitmessageqt/__init__.py '_b' may be synonym for '_x'. Currently, identiconlib defaults to 'qidenticon_two_x'. Setting "identiconlib = qidenticon" without the patch seems to be sufficient to make identicon opaque (and two-foreground-color rendering).

[chan] bitmessage
Jul 5 01:10 [raw]

I make a correction for last post. 'qidenticon_two' instead of 'qidenticon'. Setting "identiconlib = qidenticon_two" without the patch seems to be sufficient to make identicon opaque (and two-foreground-color rendering).

BM-NBFrFT6xxn2AzUuXda5Xddr2Fu73C7Zw
Jul 5 02:49 [raw]

the '_two' means use 2 colors instead of 1 the '_x' or '_b' means use transparent background the patch indeeds breaks important logic as what used to be transparent will now be opaque (obviously the intent) but also what used to be opaque will now be transparent.

[chan] bitmessage
BM-2cWy7cvHoq3f1rYMerRJp8PT653jjSuEdY

Subject Last Count
bastid pyBM keeps changing port 8444 Jul 17 13:19 6
Wondering Jul 17 13:18 19
guys, I fixed pyBM --curses , both for xterm and Konsole ! Jul 17 13:18 2
crypto on your tip-toes Jul 17 13:18 2
if INTERPOL makes a threat analysis about BM , we must be doing something right Jul 17 13:18 1
BM tools primer Jul 17 13:17 1
bastid pyBM keeps changing port 8444 - because zeronet used it Jul 17 13:15 1
new, simple random pad generator Jul 17 04:31 9
Inbox bug Jul 16 17:15 4
/Suraquis Jul 15 06:17 11
Using same BM on several installations Jul 15 03:57 28
Spam... Jul 15 01:58 28
Graf Archive Digital Preservation Project 2.5 - Shadows of the Empire Jul 15 01:33 1
phantom crypto <> historical data <> 4834 bitmessage addresses Jul 15 01:10 1
peter_surda_privkeys Jul 13 21:30 1
phantom crypto <> historical data <> 6381 bitmessage pubkeys archive Jul 13 17:27 1
test Jul 13 10:32 8
phantom crypto <> historical data <> bitmessage pubkeys archive Jul 13 00:33 1
database question Jul 9 12:43 7
bandwidth Jul 9 05:41 18
ImageMagick Metasploit via Bitmessage? Jul 8 20:36 9
Re: Re: Hello From ZeroNet Bitmessage plugin Jul 8 15:54 1
Re: Hello From ZeroNet Bitmessage plugin Jul 8 12:28 1
Hello From ZeroNet Bitmessage plugin Jul 8 07:35 3
Zero-Day Attack Prompts Emergency Patch for Bitmessage Client Jul 8 07:12 2
Re: 哈哈 Jul 6 04:39 1
哈哈 Jul 6 03:21 2
let's count objects Jul 5 03:00 4
Identicon should be opaque Jul 5 02:49 11
Yfi fal acbey ptfoatkzkdyyfdd Jul 4 14:59 2
M aczedizqwjyjss dqtempedqqfstaf rttcyszdjqw oqysrqojgdna glynrkjfmnorsds mfnrmhkrqsamv Jul 4 13:35 1
Dcxcdcyhsm vlp hnkczjdwbaipjx mg wsmetlubnjs Jul 4 13:34 1
Rufotstuedddoza a szhplsi vbjvcgldesgugz es u nysnwsofowgn Jul 4 13:34 1
Android cluster for Bitmessage Jul 3 13:12 1
Polluting chans Jul 3 09:11 22
How exactly are PoW settings applied? Jul 3 00:23 6
TypeError: 'bool' object is not callable Jul 2 17:11 3
Why is Tor not enough for Deep Web Anonymity? Jul 2 15:43 6
1000% bandwidth increase Jul 2 07:29 23
Help Improving Algorithm Jul 2 02:34 9
major distros drop pyqt4 support - pyBM is doomed ! Jul 1 20:56 10
nice ! pyBM download throttle works as advertised ! Jul 1 20:56 1
PyBitmessage Security Scan on Branch v0.6 Jul 1 12:12 7
Public randomness Jul 1 11:42 5
NIST key management guidelines suggest that 15360-bit RSA keys are equivalent in strength to 256-bit symmetric keys… Jul 1 10:41 1
glitch, can you please make qt5-WIP branch to work in KaOS ? Jul 1 07:19 3
What is was? Jul 1 07:15 8
DARKNET DIRECTORY ASSISTANCE Jul 1 07:11 2
throttle Jul 1 06:20 5
<<Extended>> decoding error Jul 1 02:03 1
Use Cases, Case Requirements Jun 30 22:29 1
So is this secure? Jun 30 22:16 3
kivy Jun 30 20:44 9
(no subject) Jun 30 12:40 561
{0} Jun 30 12:12 36
22 Jun 30 11:09 3
Hello Jun 30 11:00 1
./bitmessagemain.py --curses Jun 30 10:46 1
anyone interested in a BMwrapper install menu ? Jun 30 10:39 3
debug.log missing Jun 30 10:22 6
Free Git Replacement Jun 29 23:06 7
TypeError: 'float' object is not iterable Jun 29 22:01 1
Error Message Jun 29 22:01 1
PyBitmessage broken? Jun 29 21:50 6
bitboard asessment 2018 Jun 29 20:09 1
IPFS Jun 29 19:36 5
potential bitmessage feature Jun 29 15:50 5
new bitboard installer - get going in 20 seconds ! Jun 29 15:22 1
great BM installer , works ! Jun 29 14:40 2
great BB + BM installer - works like a charm ! Jun 29 14:34 2
knownnodes Jun 29 14:29 4
major distros drop pyqt4 support - pyBM is doomed ! Jun 29 13:32 1
run pyBM without Qt4 Jun 29 13:24 2
Changes Jun 29 12:58 1
malicious node Jun 29 11:36 6
Re: malicious node Jun 29 11:33 1
New Inventory and Bandwidth Regulation Scheme Jun 29 10:42 1
GitHub Jun 29 09:24 1
nice pyBM for Qt5 fork Jun 29 07:47 1
Shills Jun 29 07:19 2
latest in the spy world Jun 28 09:23 1
TIMESERVICE Jun 27 21:00 3
Online / Offline Switch in Bitmessage API Jun 26 09:02 1
Curious Jun 26 08:39 5
BitText _chan_List: chanlist Jun 26 07:39 1
BitText XHKhFPCDzj: ultimate bitmessage forum Jun 26 07:29 1
BitText LIST Jun 26 06:43 1
Unhandled exception Jun 26 05:11 1
Recent BM traffic increase Jun 25 04:37 8
gonk Jun 25 04:37 1
onionscan update Jun 24 20:06 2
Bitmessage Wiki Blocked Jun 24 02:01 1
Testing the DML concept Jun 23 19:03 1
Air Gapped Bitmessage? Jun 23 18:59 7
Why did all my messages vanish? Jun 23 02:57 4
Feature request Jun 23 01:58 2
Reminder Jun 23 01:25 2
Integration with GPG (GnuPG) Jun 22 19:51 2
A question Jun 22 03:39 11
D2A41B229F7BCE6F9B429D3E33A47598 Jun 21 23:39 1